Cleanup Service

* Updated .env
+ Implemented automatical removal of old logs

lib/config/config.go

@@ -1,34 +1,31 @@
 package config
 
 import (
-	"log"
 	"os"
 	"strconv"
-
-	"github.com/joho/godotenv"
 )
 
 type DHConfig struct {
-	DiskFetchFrequency int `json:"diskFetchFrequency"`
-	MaxHistoryAge      int `json:"maxHistoryAge"`
-	DatabaseFilePath   string
-	Listen             string
-	IdentityUsername   string
-	IdentityPassword   string
+	CleanupServiceFrequency int `json:"cleanupServiceFrequency"`
+	DiskFetchFrequency      int `json:"diskFetchFrequency"`
+	MaxHistoryAge           int `json:"maxHistoryAge"`
+
+	DatabaseFilePath string `json:"databaseFilePath"`
+
+	Listen string `json:"listen"`
+
+	IdentityUsername string `json:"identityUsername"`
+	IdentityPassword string `json:"identityPassword"`
 }
 
 func GetConfiguration() DHConfig {
-	// Load .env file if it exists
-	if err := godotenv.Load(); err != nil {
-		log.Println("No .env file found")
-	}
-
 	config := DHConfig{
-		DiskFetchFrequency: 5,       // default value
-		MaxHistoryAge:      2592000, // default value
-		DatabaseFilePath:   "./data.sqlite",
-		IdentityUsername:   "admin",
-		IdentityPassword:   "admin",
+		DiskFetchFrequency:      5,
+		CleanupServiceFrequency: 60,
+		MaxHistoryAge:           2592000,
+		DatabaseFilePath:        "./data.sqlite",
+		IdentityUsername:        "admin",
+		IdentityPassword:        "admin",
 
 		Listen: ":8080",
 	}
@@ -39,6 +36,12 @@ func GetConfiguration() DHConfig {
 		}
 	}
 
+	if val, exists := os.LookupEnv("CLEANUP_SERVICE_FREQUENCY"); exists {
+		if intValue, err := strconv.Atoi(val); err == nil {
+			config.CleanupServiceFrequency = intValue
+		}
+	}
+
 	if val, exists := os.LookupEnv("MAX_HISTORY_AGE"); exists {
 		if intValue, err := strconv.Atoi(val); err == nil {
 			config.MaxHistoryAge = intValue

lib/svc/service.go

@@ -14,15 +14,16 @@ import (
 
 var db *gorm.DB
 
+// Initialize the database connection
 func InitDB() {
 	var err error
 	dbPath := config.GetConfiguration().DatabaseFilePath
-	if dbPath == "" {
-		dbPath = "./data.sqlite"
-	}
 
 	db, err = gorm.Open(sqlite.Open(dbPath), &gorm.Config{})
 	if err != nil {
+		// This should basically never happen, unless the path to the database
+		// is inaccessible, doesn't exist or there's no permission to it, which
+		// should and will crash the program
 		panic("failed to connect database")
 	}
 
@@ -30,10 +31,12 @@ func InitDB() {
 	db.AutoMigrate(&hardware.HardDrive{}, &hardware.HardDriveTemperature{})
 }
 
+// Fetch the open database pointer
 func GetDatabaseRef() *gorm.DB {
 	return db
 }
 
+// Log the temperature of the disks
 func LogDriveTemps() error {
 	drives, err := hardware.GetSystemHardDrives(db, nil, nil)
 	if err != nil {
@@ -52,8 +55,9 @@ func LogDriveTemps() error {
 	return nil
 }
 
+// Run the logging service, this will periodically log the temperature of the disks with the LogDriveTemps function
 func RunLoggerService() {
-	fmt.Println("Initializing Temperature Logging Service...")
+	fmt.Println("[🦝] Initializing Temperature Logging Service...")
 
 	tickTime := time.Duration(config.GetConfiguration().DiskFetchFrequency) * time.Second
 
@@ -63,12 +67,13 @@ func RunLoggerService() {
 			time.Sleep(tickTime)
 			err := LogDriveTemps()
 			if err != nil {
-				fmt.Printf("🛑 Temperature logging failed: %s\n", err)
+				fmt.Printf("[🛑] Temperature logging failed: %s\n", err)
 			}
 		}
 	}()
 }
 
+// Generate a PNG based upon a HDD id and a date range
 func GetDiskGraphImage(hddID int, newerThan *time.Time, olderThan *time.Time) (*bytes.Buffer, error) {
 	var hdd hardware.HardDrive
 	// Fetch by a combination of fields

lib/svc/service_cleanup.go

@@ -0,0 +1,45 @@
+package svc
+
+import (
+	"fmt"
+	"time"
+
+	"tea.chunkbyte.com/kato/drive-health/lib/config"
+	"tea.chunkbyte.com/kato/drive-health/lib/hardware"
+)
+
+// Delete all thermal entries that are older than X amount of seconds
+func CleanupOldData() error {
+	cfg := config.GetConfiguration()
+
+	beforeDate := time.Now().Add(-1 * time.Duration(cfg.MaxHistoryAge) * time.Second)
+
+	deleteResult := db.Where("time_stamp < ?", beforeDate).Delete(&hardware.HardDriveTemperature{})
+	if deleteResult.Error != nil {
+		fmt.Printf("[🛑] Error during cleanup: %s\n", deleteResult.Error)
+		return db.Error
+	}
+
+	if deleteResult.RowsAffected > 0 {
+		fmt.Printf("[🛑] Cleaned up %v entries before %s\n", deleteResult.RowsAffected, beforeDate)
+	}
+
+	return nil
+}
+
+func RunCleanupService() {
+	fmt.Println("[🦝] Initializing Log Cleanup Service...")
+
+	tickTime := time.Duration(config.GetConfiguration().CleanupServiceFrequency) * time.Second
+
+	// Snapshot taking routine
+	go func() {
+		for {
+			time.Sleep(tickTime)
+			err := CleanupOldData()
+			if err != nil {
+				fmt.Printf("🛑 Cleanup process failed: %s\n", err)
+			}
+		}
+	}()
+}

lib/web/api.go

@@ -13,6 +13,7 @@ import (
 func setupApi(r *gin.Engine) {
 	api := r.Group("/api/v1")
 
+	// Fetch the chart image for the disk's temperature
 	api.GET("/disks/:diskid/chart", func(ctx *gin.Context) {
 		diskIDString := ctx.Param("diskid")
 		diskId, err := strconv.Atoi(diskIDString)
@@ -51,6 +52,7 @@ func setupApi(r *gin.Engine) {
 		}
 	})
 
+	// Get a list of all the disks
 	api.GET("/disks", func(ctx *gin.Context) {
 
 		olderThan := time.Now().Add(time.Minute * time.Duration(10) * -1)