refactor(storage): standardize size limits to use GB units

lib/server/admin_settings.go

@@ -84,8 +84,19 @@ func (app *App) handleAdminSettingsSave(ctx *gin.Context) {
 		ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid save payload"})
 		return
 	}
+	currentOverrides, err := config.ReadAdminSettingsOverrides(app.settingsOverridesPath)
+	if err != nil {
+		ctx.JSON(http.StatusInternalServerError, gin.H{"error": "Could not load current settings overrides"})
+		return
+	}
+	if currentOverrides == nil {
+		currentOverrides = map[string]string{}
+	}
+	for key, value := range request.Values {
+		currentOverrides[key] = value
+	}
 
-	rows, warnings, err := app.applySettingsOverrideSet(request.Values)
+	rows, warnings, err := app.applySettingsOverrideSet(currentOverrides)
 	if err != nil {
 		ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
 		return
@@ -168,30 +179,24 @@ func (app *App) handleAdminSettingsReset(ctx *gin.Context) {
 	var request adminSettingsResetRequest
 	_ = ctx.ShouldBindJSON(&request)
 
-	defs := config.EditableDefinitions()
-	overrideSet := make(map[string]string, len(defs))
+	overrideSet, err := config.ReadAdminSettingsOverrides(app.settingsOverridesPath)
+	if err != nil {
+		ctx.JSON(http.StatusInternalServerError, gin.H{"error": "Could not load settings overrides"})
+		return
+	}
+	if overrideSet == nil {
+		overrideSet = map[string]string{}
+	}
 	targetKeys := map[string]bool{}
 	for _, key := range request.Keys {
-		targetKeys[key] = true
+		targetKeys[config.NormalizeLegacySettingKey(key)] = true
 	}
 
 	if len(targetKeys) == 0 {
-		for _, def := range defs {
-			overrideSet[def.Key] = app.config.DefaultValue(def.Key)
-		}
+		overrideSet = map[string]string{}
 	} else {
-		currentOverrides, err := config.ReadAdminSettingsOverrides(app.settingsOverridesPath)
-		if err != nil {
-			ctx.JSON(http.StatusInternalServerError, gin.H{"error": "Could not load settings overrides"})
-			return
-		}
-		for key, value := range currentOverrides {
-			overrideSet[key] = value
-		}
-		for _, def := range defs {
-			if targetKeys[def.Key] {
-				overrideSet[def.Key] = app.config.DefaultValue(def.Key)
-			}
+		for key := range targetKeys {
+			delete(overrideSet, key)
 		}
 	}
 
@@ -203,7 +208,7 @@ func (app *App) handleAdminSettingsReset(ctx *gin.Context) {
 
 	ctx.JSON(http.StatusOK, gin.H{
 		"ok":       true,
-		"message":  "Editable settings reset to application defaults",
+		"message":  "Selected overrides cleared; environment and defaults now apply",
 		"warnings": warnings,
 		"rows":     rows,
 	})
@@ -231,7 +236,12 @@ func (app *App) applySettingsOverrideSet(values map[string]string) ([]adminSetti
 	sort.Strings(keys)
 
 	for _, key := range keys {
-		value := strings.TrimSpace(values[key])
+		normalizedKey, normalizedValue, err := config.NormalizeOverrideInput(key, strings.TrimSpace(values[key]))
+		if err != nil {
+			return nil, nil, fmt.Errorf("%s: %w", key, err)
+		}
+		key = normalizedKey
+		value := normalizedValue
 		def, ok := editable[key]
 		if !ok {
 			if _, found := config.Definition(key); found {
@@ -447,10 +457,10 @@ func settingsDescription(key string) string {
 		config.SettingRenewOnDownloadEnabled:    "Extend retention when file or ZIP downloads happen.",
 		config.SettingDefaultGuestExpirySecs:    "Default retention presented to guest uploads.",
 		config.SettingMaxGuestExpirySecs:        "Maximum retention guests may request.",
-		config.SettingGlobalMaxFileSizeBytes:    "Global single-file upload ceiling applied to future requests across the whole app.",
-		config.SettingGlobalMaxBoxSizeBytes:     "Global total box size ceiling applied to future requests across the whole app.",
-		config.SettingDefaultUserMaxFileBytes:   "Default per-user file size ceiling used by future account-aware flows.",
-		config.SettingDefaultUserMaxBoxBytes:    "Default per-user box size ceiling used by future account-aware flows.",
+		config.SettingGlobalMaxFileSizeBytes:    "Global single-file upload ceiling in GB applied to future requests across the whole app. Decimal values allowed.",
+		config.SettingGlobalMaxBoxSizeBytes:     "Global total box size ceiling in GB applied to future requests across the whole app. Decimal values allowed.",
+		config.SettingDefaultUserMaxFileBytes:   "Default per-user file size ceiling in GB used by future account-aware flows. Decimal values allowed.",
+		config.SettingDefaultUserMaxBoxBytes:    "Default per-user box size ceiling in GB used by future account-aware flows. Decimal values allowed.",
 		config.SettingSessionTTLSeconds:         "Lifetime for authenticated browser sessions, including admin session cookies.",
 		config.SettingBoxPollIntervalMS:         "Browser polling cadence for box status refreshes.",
 		config.SettingThumbnailBatchSize:        "How many thumbnail jobs the worker handles per batch.",